Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Browser: Inconsistent use of 'eg.' in Template Descriptions #52755

Closed
jordesign opened this issue Jul 19, 2023 · 9 comments · Fixed by #52848
Closed

Template Browser: Inconsistent use of 'eg.' in Template Descriptions #52755

jordesign opened this issue Jul 19, 2023 · 9 comments · Fixed by #52848
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance

Comments

@jordesign
Copy link
Contributor

Description

In the descriptions of Templates it looks like eg. is used inconsistently. I see examples of:

  • eg.
  • eg,
  • eg.,

I first spotted this on the 'All Archive' template which includes this text: This template will serve as a fallback when more specific templates (e.g., Category or Tag) cannot be found.

Screenshot 2023-07-19 at 8 50 45 pm

On reviewing the definitions (I could find) in the plugin at there appeared to be more variations for other templates.

Step-by-step reproduction instructions

Open the Site Editor > Templates and click through the Templates to see their details displayed.

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.3RC1
No Plugins
TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign jordesign added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 19, 2023
@ndiego
Copy link
Member

ndiego commented Jul 19, 2023

I agree this needs to be standardized, but given the string freeze, I think we need to punt this from 6.3. @annezazu @bph @firoz2456 can you confirm?

@annezazu
Copy link
Contributor

This is tricky and relates to a current convo in the release leads channel. TLDR: there is a string freeze but this relates to an existing string that the polyglots have, rather than providing a new thing to translate. I don't see this as creating additional work for translators based on that conversation so I could see this being a quick update as a result to handle. @tellthemachines since you helped with that last situation!

@tellthemachines
Copy link
Contributor

I'm not sure, because (if I understand correctly) we'd be making actual changes to strings instead of replacing them with existing ones. Does that mean the strings will be marked for translation instead of "fuzzy" as @azaozz mentions in that convo? Even if it's just that tiny change, if it means a translator has to go through and manually check what changed in each string then we should leave this one out.

@annezazu
Copy link
Contributor

Flagged in the release leads and polyglots to get more info!

@tobifjellner
Copy link
Contributor

String freezes are a bit less critical than before, since we now will create language packs even if a locale didn't reach exactly 100%. So if this gets fixed at least 2 weeks before release, then we'll be able to handle the changes.
This kind of small change will for a previously translated string typically create a "fuzzy": the string is not translated, but the translation platform generates an automatic suggestion with the previous translation. (And in this case, most translations won't actually change...)

Still: For reference, it would be good if you could drop a link to the commit/diff in Polyglots channel when this happens.

@tellthemachines
Copy link
Contributor

Thanks for explaining @tobifjellner ! I guess we're good to make this change for RC2 then. Now do we have any volunteers to do a PR? 😄

@jordesign
Copy link
Contributor Author

I'm willing to give it a shot - seeing as I reported it.

@jordesign jordesign self-assigned this Jul 21, 2023
@ramonjd
Copy link
Member

ramonjd commented Jul 21, 2023

I'm willing to give it a shot - seeing as I reported it.

Happy to help. Just ping if you need anything.

@jordesign
Copy link
Contributor Author

OK fingers crossed - #52848 will help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance
Projects
Development

Successfully merging a pull request may close this issue.

6 participants