Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Snackbar timeout seems to reset on each 'save' action #53016

Closed
jordesign opened this issue Jul 27, 2023 · 2 comments · Fixed by #53087
Closed

Site Editor: Snackbar timeout seems to reset on each 'save' action #53016

jordesign opened this issue Jul 27, 2023 · 2 comments · Fixed by #53087
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jordesign
Copy link
Contributor

Description

The snackbar appears to be set to have each instance fade out after 10 seconds of displaying. I found that when another 'save' action takes place it looks like it resets the counter.

In an instance where lots of changes and saves might be taking place (like the style variants) these can start to stack up significantly.

Screenshot 2023-07-27 at 8 03 19 pm

It then removes a single snackbar instance each 10s so it also takes a long time for them to move away in bulk.

Step-by-step reproduction instructions

  1. Open the site editor and go to 'Styles'.
  2. Select a new style and then click 'save'.
  3. repeat

Screenshots, screen recording, code snippet

This example is a massive exaggeration - but still possible to produce if lots of rapid changes are being made.

Screen.Recording.2023-07-27.at.8.02.25.pm.mov

Environment info

WP6.3 RC3
No plugins
TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign
Copy link
Contributor Author

There seems to have been prior discussion around the timing of the snackbars, and also their placement.

But this resetting of the dismissal timer seems an extension of that.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 27, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 28, 2023
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jul 28, 2023

I think it makes more sense to only ever display one snackbar at a time for a given action, as we are now doing in a number of other places. PR for this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants