Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align all author/avatar/profile icons #53158

Open
pablohoneyhoney opened this issue Jul 30, 2023 · 5 comments
Open

Align all author/avatar/profile icons #53158

pablohoneyhoney opened this issue Jul 30, 2023 · 5 comments
Labels
Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@pablohoneyhoney
Copy link

Ideally, all icons with a author/avatar/profile should relate. Below avatar and comment author are different; other author-based ones differ too.

Screenshot 2023-07-30 at 6 54 59 PM Screenshot 2023-07-30 at 6 54 33 PM

The first one (avatar) also has strange angles when the vertical lines collide with the bottom curve.

Screenshot 2023-07-30 at 6 56 51 PM Screenshot 2023-07-30 at 5 35 34 PM
@pablohoneyhoney pablohoneyhoney added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. labels Jul 30, 2023
@hanneslsm
Copy link

The Avatar block is also used for commenters, so I think it's fine it doesn't look like the ones that are only for the Post Author.
One could argue that the Avatar icon and the Comment Author Name could be similar.
However, the Comment Author Name is inspired by the Comment Content, which also makes sense.

image

@jasmussen
Copy link
Contributor

jasmussen commented Jul 31, 2023

Good one, these definitely need a pass. The comment author also looks a bit too close to the bottom of the bubble, and ibalanced with its head floating high above the body. I'll see if I can't do a pass on all of these.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 1, 2023
@jameskoster
Copy link
Contributor

I'd like to see Post Author Name and Comment Author Name combined into a single 'Author Name' block, as we've already done with Avatar. They can then share an icon.

With that said, here's a first take on this:

Author

The icon for Author name shares DNA with similar blocks e.g. Site Title, Post Title. The shape of the figure better matches others in the 'set'.

Worth noting that the Post author block is due for deprecation, to be replaced by a pattern.

@jasmussen
Copy link
Contributor

Thanks for tackling this!

These are all better, though your point is well made around consolidation. It seems like we have a lot of very specific icons to target very specific blocks; this is mainly to differentiate different them from each other in the list view. But it seems like there may be a better way here, perhaps a pattern for how we do this. The last attempt to find a pattern was to have the big icon for the main concept and small icon plus two rows of mockup text below for a block version of that concept.

So if we zoom out, there may be an issue with the naming as a starting point. Instead of "Post author", "Post author name", "Avatar", and "Post Author Biography", perhaps we could approach it differently:

Author is the main block, renamed from "Post Author" because presumably it works in more than posts. It could be just the person, something like this:

Screenshot 2023-08-09 at 09 28 22

Avatar could remain the same, it feels solid enough in the name and design.

Author biography could then be the existing "post author" icon:

Screenshot 2023-08-09 at 09 26 17

Author name could then be a variation on that, like so:

Screenshot 2023-08-09 at 09 32 09

And speaking of consolidation, do we need separate blocks for "comment author gravatar" (sic) and "comment author"s? It would seem better if one and the same author or avatar blocks would simply be context aware and work in both places.

Even if we can't unify the blocks, we should almost certainly use the same icons, so we could retire these two:
Screenshot 2023-08-09 at 09 25 12

Screenshot 2023-08-09 at 09 30 52

What do you think? Nice work!

@jameskoster
Copy link
Contributor

Post Author should be deprecated imo, as Comment Author was (in fact I'm not sure Comment Author ever existed).

Author biography could then be the existing "post author" icon

Could work, but it goes against the convention where that format is used for 'title' blocks.

And speaking of consolidation, do we need separate blocks for "comment author gravatar" (sic) and "comment author"s?

Comment Author doesn't exist. The comment blocks relating to author are Avatar, and Comment Author Name. Ideally Post Author Name and Comment Author Name are combined into a single Author Name block, the same was Post Author Avatar and Comment Author Avatar were combined into Avatar.

Imo these are the blocks it makes sense to concentrate efforts around:

  • Author Name
  • Author Biography
  • Avatar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants