Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Author Block: Avatar doesn't respect the border radius setting #53687

Open
iamtakashi opened this issue Aug 15, 2023 · 3 comments
Open

Post Author Block: Avatar doesn't respect the border radius setting #53687

iamtakashi opened this issue Aug 15, 2023 · 3 comments
Labels
[Block] Avatar Affects the Avatar Block [Block] Post Author Affects the Post Author Block [Type] Enhancement A suggestion for improvement.

Comments

@iamtakashi
Copy link

iamtakashi commented Aug 15, 2023

Description

The avatar in the Post Author block doesn't respect the border-radius setting in the Avatar block. Since the Post Author block doesn't supply a separate border-radius setting, the avatar should inherit the setting in the Avatar block.

Step-by-step reproduction instructions

  1. Go to the editor.
  2. Set the border-raidus in the Avatar block, let's say 999px.
  3. See the avatar in the Post Author block.

Screenshots, screen recording, code snippet

Screenshot 2023-08-15 at 16 44 33

Environment info

  • WP 6.3
  • Gutenberg Trunk
  • Chrome Mac

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jorgefilipecosta jorgefilipecosta added [Type] Enhancement A suggestion for improvement. [Block] Avatar Affects the Avatar Block [Block] Post Author Affects the Post Author Block labels Aug 15, 2023
@jorgefilipecosta
Copy link
Member

I believe the author's post block ought to be refactored to utilize a nested blocks section, with the avatar being just one of those nested blocks. This alteration would provide greater style control and promptly resolve the present problem.

@iamtakashi iamtakashi changed the title Post Author Block: Avatar isn't respect the border radius setting Post Author Block: Avatar doesn't respect the border radius setting Aug 15, 2023
@richtabor
Copy link
Member

I believe the author's post block ought to be refactored to utilize a nested blocks section, with the avatar being just one of those nested blocks. This alteration would provide greater style control and promptly resolve the present problem.

Or perhaps deprecated. Not sure we need a post author block when we have author avatar, name and biography individually now.

@t-hamano
Copy link
Contributor

I found #53427 which suggests deprecating this block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Avatar Affects the Avatar Block [Block] Post Author Affects the Post Author Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants