Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Template Parts/Pattern options menu doesn't hide after selecting rename #54702

Closed
cuemarie opened this issue Sep 21, 2023 · 3 comments
Closed
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@cuemarie
Copy link

cuemarie commented Sep 21, 2023

Description

When you try to rename a template part or pattern, the context menu doesn't auto-hide and can overlap the Rename module.

Step-by-step reproduction instructions

  1. Open Appearance > Editor > Patterns
  2. Select a category under Template Parts like Header
  3. Create a custom Header Template Part (you can just duplicate the default "Header" using the ... menu)
  4. On a custom Template Part, select ... > Rename

Screenshots, screen recording, code snippet

Screen.Capture.on.2023-09-21.at.12-04-09.mov

Environment info

  • WP 6.3.1 running Twenty Twenty Three
  • Gutenberg 16.6.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign
Copy link
Contributor

Confirmed in my testing as well. I noticed that with GB deactivated the menu still says visible - but the z-index is lower than the modal, so the experience is not as poor.

With GB active
Screenshot 2023-09-22 at 7 18 59 am

With GB deactivated

Screenshot 2023-09-22 at 7 20 05 am

@jordesign jordesign added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Sep 21, 2023
@jordesign jordesign changed the title Rename Template Parts options menu doesn't hide after selecting rename Rename Template Parts/Pattern options menu doesn't hide after selecting rename Sep 21, 2023
@jordesign
Copy link
Contributor

I could also recreate this for renaming patterns as well - so I've updated the title to reflect that.

@Mamaduka
Copy link
Member

This was fixed in #54277. I can't reproduce the issue on the trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants