Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on click lightbox is activated on subsequent block images #55467

Closed
JosVelasco opened this issue Oct 18, 2023 · 5 comments
Closed

Expand on click lightbox is activated on subsequent block images #55467

JosVelasco opened this issue Oct 18, 2023 · 5 comments
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@JosVelasco
Copy link

Description

If the Expand on click option is activated for a block image, the subsequent image blocks will enable this function even if the switch is not selected.

The blocks above the one that has the lightbox activated won't have this function activated.

Step-by-step reproduction instructions

  1. Insert one image block.
  2. Insert another image block and enable the Expand on click option.
  3. Insert another image block without enabling the Expand on click option.
  4. Confirm the third image block has the lightbox enabled on the front-end.

Screenshots, screen recording, code snippet

https://youtu.be/HDP4VCMt5CA

Environment info

  • WP 6.4-RC1 and Gutenberg Version 16.8.1 activated. Twenty Twenty-Three theme.
  • Chrome 118.0.5993.88 (Build oficial) (arm64)
  • MacBook with Sonoma 14.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Oct 19, 2023
@karmatosed
Copy link
Member

I can confirm this is happening for me and give a bit more details from testing. This seems to be only happening using the Gutenberg plugin so something not in 6.4 but since the merge there.

@karmatosed karmatosed added the [Block] Image Affects the Image Block label Oct 19, 2023
@colorful-tones
Copy link
Member

This happened to me yesterday in my 6.4 walk-through, and I was running the same installation as reported.

@colorful-tones
Copy link
Member

Note: this issue is not happening with latest Gutenberg trunk.

@colorful-tones
Copy link
Member

It seems like this was addressed in #55120. However, if we want the Lightbox roll-out to be successful then I would prioritize cherry-picking that into a release (if possible) before the final WP 6.4 lands.

@karmatosed @mikachan for visibility.

@colorful-tones
Copy link
Member

and @mikachan is already ahead of us all! She cherry-picked the change already. 👏

Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants