Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve replacing patterns #55518

Open
JosVelasco opened this issue Oct 20, 2023 · 2 comments
Open

Improve replacing patterns #55518

JosVelasco opened this issue Oct 20, 2023 · 2 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@JosVelasco
Copy link

What problem does this address?

When using the Site Editor, after clicking on a pattern, the Replace pattern button is located in the secondary menu, making it difficult to find.

Captura de pantalla 2023-10-20 a la(s) 11 19 28 a m

Clicking Edit will open the pattern in an isolated mode without an easy way to replace the blocks other than inserting a pattern from the block inserter.

Captura de pantalla 2023-10-20 a la(s) 11 20 10 a m

What is your proposed solution?

  • Add a Replace pattern button next to the Edit in the toolbar. It could be labeled as it is now in the secondary menu. For example, Replace Header or Replace.

Captura de pantalla 2023-10-20 a la(s) 11 22 39 a m

  • When on insolated mode, Add a Replace button in the top toolbar, next to the Edit pincel or the List View icon. This could also help the user select from more options if they edit the template part from Appearance > Editor > Patterns > Template part.

Captura de pantalla 2023-10-20 a la(s) 11 20 10 a m

@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Oct 20, 2023
@richtabor
Copy link
Member

richtabor commented Oct 20, 2023

I too think "Replace" is a bit hidden, though I think that when #55091 is merged it'll alleviate this a bit. As then the alternate headers/footers would be visible in the block inspector to choose from (instead of the replace modal. 🤔

When on insolated mode, Add a Replace button in the top toolbar, next to the Edit pincel or the List View icon. This could also help the user select from more options if they edit the template part from Appearance > Editor > Patterns > Template part.

But this is certainly covered by #55091; I don't think we need a header button specifically.

@richtabor richtabor added [Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts labels Oct 20, 2023
@JosVelasco
Copy link
Author

Thanks for showing me #55091 @richtabor!

As someone who uses a small screen, I'm always concerned about panels showing previews. I prefer the modal, which is wider.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants