Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Expanding quick-actions for Pages #55628

Closed
9 tasks
jameskoster opened this issue Oct 25, 2023 · 9 comments
Closed
9 tasks

Data views: Expanding quick-actions for Pages #55628

jameskoster opened this issue Oct 25, 2023 · 9 comments
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Oct 25, 2023

page quick actions

#55488 enables 'quick actions' in data views. For pages this initially includes primary actions; View, Trash, and the secondary actions: Edit and View revisions.

We can expand upon this by adding:

  • Edit Title – opens a modal similar to renaming a template or pattern
  • Edit slug – opens a modal with contents similar to the slug editing popover in the post editor
  • Edit status – opens a flyout with status options
  • Edit author – opens a flyout with scrollable & searchable list of authors
  • Edit publish date - opens a modal with a datepicker like in the post editor
  • Disable/Enable comments
  • Swap template – opens the same modal you find when editing a page in the site editor
  • Edit visibility – opens a modal with a similar UI to the 'Visibility' popover in the post editor
  • Edit page parent – opens a flyout with scrollable & searchable list of pages

I suspect much of the design work can occur alongside PR's. But if there's anything we need to dive deeper on before work begins let me know @ntsekouras.

It's also worth noting that the modals here could also potentially be opened when clicking values in table views (#55101), and when performing bulk actions (#55098).

cc @WordPress/gutenberg-design for further feedback.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Oct 25, 2023
@jasmussen
Copy link
Contributor

An immediate thought is that this is a lot of repeated instances of the word "Edit". A more expanded question is whether we can bunch these together as a single, or a few, grouped quick-edit instances. "Edit properties" or "Edit details", something in that vein.

@jameskoster
Copy link
Contributor Author

We could probably omit the repetitive 'Edit...' prefix 👍 The argument to keep each action separate is that they can all be invoked from different flows, e.g.: clicking the values in the table row (inline editing), or bulk actions. Some (like swapping the template) can be invoked from the main document inspector in edit mode too. So it's a case of reusing as much as possible to establish consistency across.

That said, grouping could potentially work similar to wp-admin (albeit with a more considered design). IE a single "Quick edit" action that opens a modal containing all the document meta.

Alternatively the quick actions menu itself might be organised to make use of flyouts. I'll try a couple of mockups.

@jameskoster
Copy link
Contributor Author

Here's a version that groups some options together and utilises flyouts:

page quick actions

This feels like a contextual menu and works well imo. The same menu could be revealed when right-clicking a row.


Here's a mockup encapsulating all quick-edit options in a modal, similar to editor preferences:

modal

The modal approach provides much more room for manoeuvre per section, but I'm not sure they really need it. The flows that require a modal (changing publish date, template, etc.) would make use of one regardless.

@paaljoachim
Copy link
Contributor

This looks real interesting James!

@jasmussen
Copy link
Contributor

Might work. Some of the answers might present themselves as we explore in a PR, but I just wonder if in some cases, a single modal opening from the menu, rather than navigating the dropdown, is easier.

@jameskoster
Copy link
Contributor Author

I have a slight preference for discrete flows per action because it's more lightweight / reusable. But totally open to trying both approaches in a PR 👍

@ntsekouras
Copy link
Contributor

This issue is really connected to inline editing of fields, and should be addressed probably when we implement that. The goal is to define descriptions for fields, which will generate the editing of them.

@jameskoster
Copy link
Contributor Author

Yes there is considerable overlap. The same UI can theoretically be used for both inline-edits, and quick actions, e.g.:

reuse

@jameskoster
Copy link
Contributor Author

I think the recent Inspector work may influence the direction here. Closing for now, easy to re-open if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants