Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Block: Heading color option appears in 6.4 RC #55653

Closed
cbirdsong opened this issue Oct 26, 2023 · 5 comments
Closed

Cover Block: Heading color option appears in 6.4 RC #55653

cbirdsong opened this issue Oct 26, 2023 · 5 comments
Labels
[Feature] Colors Color management [Type] Question Questions about the design or development of the editor.

Comments

@cbirdsong
Copy link

In 6.4 RC 2 the cover block has a heading color option:

Wordpress block sidebar showing text, heading and overlay color options

I tested this on both a hybrid/traditional theme and a FSE theme and it appears on both. It can be removed by adding "heading": false inside the color key in theme.json, but the schema thinks this is invalid.

Is all this intentional? I can't find any mention of it in the 6.4 field guide.
@cbirdsong cbirdsong added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Colors Color management Needs Technical Feedback Needs testing from a developer perspective. labels Oct 26, 2023
@jordesign jordesign added the [Type] Question Questions about the design or development of the editor. label Oct 26, 2023
@t-hamano
Copy link
Contributor

This feature seems to have been added in #49131. However, it looks like the theme.json schema is not updated.

@cbirdsong
Copy link
Author

I don't see it in any other block, including the ones mentioned in the PR?

@t-hamano
Copy link
Contributor

Since __experimentalDefaultControls is defined in blocks other than the cover block, it is not displayed by default. The cover block does not have __experimentalDefaultControls property, so all color support will be displayed by default. Please click on the ellipsis button.

heading

@t-hamano
Copy link
Contributor

I submitted #55675 to update the schema of block.json and #55674 to update the schema of theme.json.

@t-hamano t-hamano removed Needs Technical Feedback Needs testing from a developer perspective. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Oct 28, 2023
@annezazu
Copy link
Contributor

I'm going to close this out unless anything remains unresolved! Doing a sweep for 6.4. Happy to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Colors Color management [Type] Question Questions about the design or development of the editor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cbirdsong @jordesign @annezazu @t-hamano