Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more specific when handling escape deselect from block editor #56045

Closed
jeryj opened this issue Nov 10, 2023 · 1 comment
Closed

Be more specific when handling escape deselect from block editor #56045

jeryj opened this issue Nov 10, 2023 · 1 comment
Assignees
@jeryj
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@jeryj
Copy link
Contributor

jeryj commented Nov 10, 2023 •
edited

Follow-up to #55787

The unselect escape shortcut is too unrestricted about what it catches. It will run and deselect a block, causing a focus loss anytime the escape key is pressed and a block is selected, even if that's an unexpected action.

For example, if focus is within the block sidebar, an escape keypress will deselect the block and lose focus. An unexpected side effect.
@jeryj jeryj added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 10, 2023
@jeryj jeryj self-assigned this Nov 10, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Nov 12, 2023
@jeryj
Copy link
Contributor Author

jeryj commented Feb 5, 2024

Fixed by #58637

@jeryj jeryj closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeryj jeryj

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
Automattic team Ignite's project board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeryj @jordesign