Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox: Expand on click toggle control is disabled on images inserted through the block inserter sidebar #56049

Closed
bacoords opened this issue Nov 10, 2023 · 3 comments · Fixed by #56053
Closed

Lightbox: Expand on click toggle control is disabled on images inserted through the block inserter sidebar #56049

bacoords opened this issue Nov 10, 2023 · 3 comments · Fixed by #56053
Assignees
@t-hamano
Labels
[Block] Image Affects the Image Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@bacoords
Copy link
Contributor

bacoords commented Nov 10, 2023 •
edited

Description

When inserting an image from the block inserter sidebar (either Openverse or media library), the 'Expand on click' toggle is disabled at first, even though the image is not actually linked. (If you add a link and then remove it, the toggle then is enabled.)

Step-by-step reproduction instructions

  1. Open a new post
  2. Open the block inserter left side panel, select Media, select Openverse or Images,
  3. Select an image to insert it
  4. See that the 'Expand on click' toggle is disabled.

Screenshots, screen recording, code snippet

Screen.Recording.2023-11-10.at.11.59.09.AM.mov

Environment info

  • WP 6.4.1, no GB plugin
  • Tested on Chrome and Arc

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

CC @aurooba
@bacoords bacoords added the [Type] Bug An existing feature does not function as intended label Nov 10, 2023
@aurooba aurooba added the [Block] Image Affects the Image Block label Nov 10, 2023
@aurooba
Copy link
Member

aurooba commented Nov 10, 2023

I'm able to reproduce this on my end on a clean install following the steps!

@bacoords bacoords changed the title Lightbox: Expand on click toggle control is disabled on Openverse images Lightbox: Expand on click toggle control is disabled on images inserted through the block inserter sidebar Nov 10, 2023
@t-hamano t-hamano mentioned this issue Nov 11, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 11, 2023
@sajmes
Copy link

sajmes commented Apr 7, 2024 •
edited

Appears this may be happening again. Simple site: 8002908-zd-a8c

@t-hamano
Copy link
Contributor

t-hamano commented Apr 8, 2024

@sajmes Could you tell me which WordPress version you tested it on? I tested it with both WP 6.5 and the latest Gutenberg, but I couldn't reproduce it. By the way, this setting has been moved from the sidebar to the block toolbar.

dc684343fb51abb51e2c710ae122d850.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Block] Image Affects the Image Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lightbox: Fix "Expand on click" control being disabled unintentionally WordPress/gutenberg
4 participants
@bacoords @aurooba @t-hamano @sajmes