Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-publish checks naming consistency #56977

Closed
afercia opened this issue Dec 12, 2023 · 0 comments · Fixed by #57019
Closed

Pre-publish checks naming consistency #56977

afercia opened this issue Dec 12, 2023 · 0 comments · Fixed by #57019
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Dec 12, 2023

Description

The Pre-publish checks naming is inconsistent across the UI.

As a user, it is confusing for me to see different names all over the UI that refer to the same feature. Some consistency would help.

Also, I'm not sure the term 'flow' introduced in #56481 is clear enough for users, as it sounds more a technical term related to UX design.

It would be great to have some naming consistency and use a simple, understandable, term. Cc @mtias

Screenshots:

Pre and post publish panels in the sidebar use the term 'checks':

sidebar

Preferences modal dialog uses the term 'flow':

preferences modal dialog

Command palette uses the term 'checklist':

command palette

Confirmation snackbar after using the Command palette uses the term 'checklist':

snackbar

Search for the string pre-publish within translatable strings through the codebase finds a few occurrences highlighting the naming inconsistency:

Screenshot 2023-12-07 at 13 25 23

Although these inconsistencies don't impact the technical functionality, they make user experience not ideal and make the Editor be perceived like an unpolished user interface. It would be great to see more focus on this kind of important details.

Step-by-step reproduction instructions

  • Publish a post and observe the pre-publish checkbox at the bottom of the sidebar.
  • Open the preferences modal dialog and observe the pre-publish toggle.
  • Use the command center, search for 'pre-publish' and observe the suggested command.
  • Click the suggested command and observe the snackbar notice.
  • In all cases above, observe the naming inconsistency.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Package] Edit Post /packages/edit-post labels Dec 12, 2023
@afercia afercia self-assigned this Dec 13, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant