Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using standard category UI for synced pattern categories #57129

Open
richtabor opened this issue Dec 15, 2023 · 2 comments
Open

Consider using standard category UI for synced pattern categories #57129

richtabor opened this issue Dec 15, 2023 · 2 comments
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the editor.

Comments

@richtabor
Copy link
Member

I'm curious, is there a reason why synced patterns don't use the typical category selection UI that all other post types leverage? Perhaps to reduce the footprint of the create pattern modal?

They're currently implemented like tags, which lead to unexpected results (related #57094).

Pattern categories:

CleanShot 2023-12-15 at 17 10 28

Other post types:

CleanShot 2023-12-15 at 17 13 57

@richtabor richtabor added [Type] Question Questions about the design or development of the editor. Needs Design Feedback Needs general design feedback. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Dec 15, 2023
@talldan
Copy link
Contributor

talldan commented Dec 18, 2023

@richtabor Pattern categories are non-hierarchical like tags, while post categories are hierarchical taxonomies.

So because of that the non-hierachical control is used for pattern categories. I don't see a reason why it couldn't be more like the control used for posts, but perhaps without the parent selector.

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Dec 18, 2023

We did look at using something similar to the category selection, but it took up a look of extra space in the add pattern model. The form token tag input is much more compact in that context:

Screenshot 2023-12-18 at 7 07 29 PM

and we thought it best to have the same input in both places. A decision that can be revisiting of course.

If we stick with the token input maybe we should look at making the select list expand on focus in the sidebar control like it does in the modal?

Screenshot 2023-12-18 at 7 10 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants