Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archives: Ignores the padding set in theme.json #57285

Closed
iamtakashi opened this issue Dec 20, 2023 · 2 comments
Closed

Archives: Ignores the padding set in theme.json #57285

iamtakashi opened this issue Dec 20, 2023 · 2 comments
Labels
[Block] Archives Affects the Archives Block Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@iamtakashi
Copy link

Description

The archives block doesn't respect the setting in theme.json. This is only a problem in the editor. The block renders fine on the front of the site.

For example, TT4 only specifies the list block's padding, which should be respected in both the archives and the page list blocks. But the archives block keeps the default padding. Hence, they don't align.

Screenshot 2023-12-20 at 19 37 50

Another example with a different theme, the theme specifies the padding in theme.json, but it's ignored.

Screenshot 2023-12-20 at 19 44 33

The issue remains even without Gutenberg activated. Does this mean this is the wrong place to report the issue? If so, let me know the best place.

Step-by-step reproduction instructions

  • Open the editor and add an archives block.
  • Edit theme.json to change the padding.
{
	"styles": {
		"blocks": {
			"core/archives": {
				"spacing": {
					"padding": {
						"left": "50px"
					}
				}
			}
		}
	}
{
  • Back to the editor and see the padding doesn't match in the archives block

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 6.4.2
  • Gutenberg Trunk (although the issue remains without the plugin)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@iamtakashi iamtakashi added the [Type] Bug An existing feature does not function as intended label Dec 20, 2023
@jordesign jordesign added Needs Testing Needs further testing to be confirmed. [Block] Archives Affects the Archives Block labels Dec 20, 2023
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jan 20, 2024
@iamtakashi
Copy link
Author

I can't replicate this anymore. It looks like it was fixed somewhere. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Archives Affects the Archives Block Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants