Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Caption component is rendered when multiple blocks are selected #57369

Closed
t-hamano opened this issue Dec 26, 2023 · 2 comments
Closed

Block Library: Caption component is rendered when multiple blocks are selected #57369

t-hamano opened this issue Dec 26, 2023 · 2 comments
Assignees
@Mamaduka
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Video Affects the Video Block [Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Dec 26, 2023 •
edited

Description

Similar to #57357

A common Caption component is currently used to render the caption in the following blocks:

  • Image
  • Audio
  • Gallery
  • Video

The Caption control also appears on the block toolbar when multiple blocks are selected. This is unexpected behavior, and nothing happens when you click, and you may inadvertently delete caption text.

Step-by-step reproduction instructions

Note: As for the Image block, it will be solved by #57357.

  • Insert multiple blocks of Gallery, Video, or Image.
  • Select those blocks.
  • A caption button should now appear on the block toolbar.

Screenshots, screen recording, code snippet

e839a2895221d497fcabf7326cdc5820.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Block] Image Affects the Image Block [Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Video Affects the Video Block labels Dec 26, 2023
@t-hamano t-hamano mentioned this issue Dec 26, 2023
Merged
@t-hamano t-hamano added the [Package] Block library /packages/block-library label Dec 26, 2023
@Mamaduka Mamaduka removed the [Block] Image Affects the Image Block label Dec 26, 2023
@Mamaduka
Copy link
Member

@t-hamano, I will tentatively assign this to myself and try to push PR later today.

@Mamaduka Mamaduka self-assigned this Dec 26, 2023
This was referenced Dec 26, 2023
Merged
Merged
Merged
@t-hamano
Copy link
Contributor Author

I would like to close this issue as it has been fixed in all blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Video Affects the Video Block [Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mamaduka @t-hamano