Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken "Improve on GitHub" links in Handbook #57630

Closed
hirasso opened this issue Jan 7, 2024 · 4 comments
Closed

Broken "Improve on GitHub" links in Handbook #57630

hirasso opened this issue Jan 7, 2024 · 4 comments
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers

Comments

@hirasso
Copy link

hirasso commented Jan 7, 2024

Description

On https://developer.wordpress.org/block-editor/, the links on every page "Improve it on GitHub" contain an empty href attribute. I wasn't able to find the related repository, so leaving this note here. Can someone move it to the correct repo? Thanks 🙏

Step-by-step reproduction instructions

  1. Go to one of the handbook subpages, Extending the Query Loop block for example
  2. Scroll down to the link "Improve on GitHub"
  3. Click it (page reloads as the href is empty)

Screenshots, screen recording, code snippet

CleanShot 2024-01-07 at 16 31 49@2x

CleanShot 2024-01-07 at 16 32 52@2x

Environment info

n/a

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@hirasso hirasso added the [Type] Bug An existing feature does not function as intended label Jan 7, 2024
@hirasso hirasso changed the title [handbook] Broken "improve on GitHub" links [handbook] Broken "Improve on GitHub" links in Handbook Jan 7, 2024
@hirasso hirasso changed the title [handbook] Broken "Improve on GitHub" links in Handbook Broken "Improve on GitHub" links in Handbook Jan 7, 2024
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jan 7, 2024
@skorasaurus
Copy link
Member

Hi,

Thanks for reporting with the clear screenshot and information; I think this is the correct place for the issue.

@ramonjd
Copy link
Member

ramonjd commented Jan 7, 2024

Could this be a duplicate of WordPress/wporg-developer#438

cc @ndiego

I couldn't find a corresponding file in the Gutenberg repo.

I think we can close this issue in favour of the one above or it could be moved to https://github.com/WordPress/Documentation-Issue-Tracker/issues.

@hirasso
Copy link
Author

hirasso commented Jan 8, 2024

@ramonjd I can't tell if it's a duplicate, since I can't log in to the handbook. But it sure looks related. Feel free to close/move this as you see fit.

@skorasaurus
Copy link
Member

thanks; this does appear to be a duplicate of WordPress/wporg-developer#438.

Thank you again for reporting @hirasso

@skorasaurus skorasaurus added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

No branches or pull requests

3 participants