Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data views: Fix preview element display consistency #57649

Closed
3 tasks done
jameskoster opened this issue Jan 8, 2024 · 0 comments · Fixed by #57919
Closed
3 tasks done

Data views: Fix preview element display consistency #57649

jameskoster opened this issue Jan 8, 2024 · 0 comments · Fixed by #57919
Assignees
@jameskoster
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Jan 8, 2024 •
edited

Currently, only List layout has the correct implementation:

Screenshot 2024-01-08 at 15 41 49
  • Gray background on placeholders.
  • 1px semi-transparent border (to ensure the image boundaries are always visible).

The following need to be addressed:

  • Pages – Grid layout: gray background is missing on placeholders.
  • Pages – Table layout: placeholder is missing entirely. Border is missing.
  • Patterns – border is missing. Fixed in Update Grid layout design #57880

Ideally this would be implemented in a way that is easy for third parties to replicate.
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Jan 8, 2024
@jameskoster jameskoster mentioned this issue Jan 8, 2024
Open
@jameskoster jameskoster mentioned this issue Jan 17, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskoster jameskoster

Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Pages preview field display WordPress/gutenberg
1 participant
@jameskoster