Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkControl: Add support for images for in attachment search results #57776

Open
richtabor opened this issue Jan 11, 2024 · 1 comment · May be fixed by #57824 or #58458
Open

LinkControl: Add support for images for in attachment search results #57776

richtabor opened this issue Jan 11, 2024 · 1 comment · May be fixed by #57824 or #58458
Assignees
@MaggieCabrera
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

It would be nice to see previews of image attachments within LinkControl search results, rather than the folder icon. As the types only support "attachment" (not specifically image), I'm not sure what we'd need to adapt behind-the-scenes.

I'd expect the preview to also utilize the image.

Visuals

Current:

CleanShot 2024-01-11 at 14 54 19

Proposed:

CleanShot 2024-01-11 at 14 53 40

CleanShot 2024-01-11 at 14 56 50
@richtabor richtabor added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement. labels Jan 11, 2024
@richtabor richtabor changed the title LinkControl: Add support for images for image attachment search result LinkControl: Add support for images for in attachment search results Jan 11, 2024
@n2erjo00 n2erjo00 linked a pull request Jan 13, 2024 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 13, 2024
@MaggieCabrera MaggieCabrera self-assigned this Jan 30, 2024
@MaggieCabrera MaggieCabrera linked a pull request Jan 30, 2024 that will close this issue
Open
@MaggieCabrera
Copy link
Contributor

Can you let me know the sizes of the images on both cases and the border radius values, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaggieCabrera MaggieCabrera

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
2 participants
@richtabor @MaggieCabrera