Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detaching patterns loses the overrides #58122

Closed
kevin940726 opened this issue Jan 23, 2024 · 0 comments · Fixed by #58164
Closed

Detaching patterns loses the overrides #58122

kevin940726 opened this issue Jan 23, 2024 · 0 comments · Fixed by #58164
Assignees
@kevin940726
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kevin940726
Copy link
Member

Description

Part of #53705.

Detaching a pattern with overrides will not retain the overridden values after converting to blocks.

Step-by-step reproduction instructions

  1. Follow the instructions in Pattern Overrides epic (WordPress 6.5) #53705 (comment) to create a pattern with overrides and insert it into a post.
  2. Make some edits and detach the pattern.
  3. Expect the overridden values to not be lost.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Jan 23, 2024
@kevin940726 kevin940726 self-assigned this Jan 23, 2024
This was referenced Jan 23, 2024
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin940726 kevin940726

Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix losing overrides after detaching patterns WordPress/gutenberg
1 participant
@kevin940726