Font Library: font families endpoints context default to 'edit'.

[matiasbenedetto]

Description

/font-families/ endpoints default context patameter to edit instead of view. But amost all the core endpoints set the default thecontext parameter to view. Let's change it to default to view.

gutenberg/lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php

Line 341 in ecda32e

$query_params['context']['default'] = 'edit';

gutenberg/lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php

Lines 365 to 378 in ecda32e

	/**
	* Retrieves the query params for the font family collection, defaulting to the 'edit' context.
	*
	* @since 6.5.0
	*
	* @param array $args Optional. Additional arguments for context parameter. Default empty array.
	* @return array Context parameter details.
	*/
	public function get_context_param( $args = array() ) {
	if ( isset( $args['default'] ) ) {
	$args['default'] = 'edit';
	}
	return parent::get_context_param( $args );
	}

Why?

It seems like we misinterpreted the meaning of the context parameter, and we used view because the font families are used by default in the editor, but that seems to be unrelated.

I didn't find the docs in the rest API handbook about it, but this reading is useful: https://make.xwp.co/2017/07/25/defining-context-in-the-wp-rest-api/

Step-by-step reproduction instructions

• check the context default in lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php and compare it with most core endpoints.

Screenshots, screen recording, code snippet

Screenshot of a search in core codebase:

Environment info

• Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[creativecoder]

Thanks for taking a closer look at this, the linked article was very informative. I've opened a PR to update font-families and font-faces endpoints here: #58287

[matiasbenedetto]

fixed by: #58287