Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Ensure setting values are sanitized #58464

Closed
creativecoder opened this issue Jan 30, 2024 · 1 comment
Closed

Font Library: Ensure setting values are sanitized #58464

creativecoder opened this issue Jan 30, 2024 · 1 comment
Labels
[Feature] Font Library [Type] Enhancement A suggestion for improvement.

Comments

@creativecoder
Copy link
Contributor

What problem does this address?

Font Library values need to be sanitized

  • URLs: font family and face previews, font face src
  • Other font family and face settings: slug, fontFamily, fontWeight, etc
  • All of the above in Font Collections

What is your proposed solution?

  • Use theme.json sanitization for corresponding theme.json font properties
  • For remaining properties, use appropriate sanitization functions for preview (e.g. sanitize_url, sanitize_key, etc)
@creativecoder creativecoder mentioned this issue Feb 2, 2024
Merged
@creativecoder
Copy link
Contributor Author

With #58636 and #58590 merged, this should be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Font Library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@creativecoder