Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cover Block empty state #58937

Closed
pitamdey opened this issue Feb 12, 2024 · 2 comments
Closed

Improve Cover Block empty state #58937

pitamdey opened this issue Feb 12, 2024 · 2 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.

Comments

@pitamdey
Copy link

What problem does this address?

when we add a cover block and don't select anything and then see the preview in front-end it shows a blank cover
Recording : https://www.loom.com/share/9ed547c001a04009b1b3e4a7791c7616?sid=d3969784-0f5a-4756-9c49-e6044c192a87

What is your proposed solution?

I think we should not show anything if no cover photo or color is selected
@pitamdey pitamdey added the [Type] Enhancement A suggestion for improvement. label Feb 12, 2024
@jordesign jordesign added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Feb 12, 2024
@jordesign jordesign changed the title Improved Cover Block Improve Cover Block empty state Feb 12, 2024
@sunil25393
Copy link
Contributor

Probably duplicate of #10854
@annezazu we can close this issue.

@annezazu
Copy link
Contributor

Agreed! Thanks for flagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jordesign @annezazu @sunil25393 @pitamdey