Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor / Twenty Twenty-Four: Rich text gets black border #58992

Closed
t-hamano opened this issue Feb 14, 2024 · 3 comments
Closed

Site Editor / Twenty Twenty-Four: Rich text gets black border #58992

t-hamano opened this issue Feb 14, 2024 · 3 comments
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Feb 14, 2024

Update: This issue is specific to the TT4 theme and appears to be related to a core ticket aimed at improving focus outlines.

https://core.trac.wordpress.org/ticket/60334

Description

For example, in the case of a table block, when you focus on a cell, a black border will appear.

image

The paragraph block displays both a black border and a blue border.

image

This issue appears to occur in the site editor and not the post editor.

Step-by-step reproduction instructions

  • Open the Site editor.
  • Insert a table block or a paragraph block.
  • Click a cell in a table block or a paragraph block.

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress Version: WordPress 6.5-beta1-57631
  • Gutenberg Version: 17.7.0-rc.1 (Can be reproduced even if disabled)
  • OS: Windows 11
  • Browser: Chrome 121.0.6167.162, Firefox 122.0.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Feb 14, 2024
@t-hamano
Copy link
Contributor Author

The outline style of the .wp-site-blocks *:focus selector appears to override the rich text outline: none.

image

@t-hamano t-hamano changed the title Site Editor: Rich text gets black border Site Editor / Twenty Twenty-Four: Rich text gets black border Feb 14, 2024
@carolinan
Copy link
Contributor

I did not realise wp-site-blocks was also in the Site editor. What would be a better selector?

@t-hamano
Copy link
Contributor Author

@carolinan It might be a good idea to discuss this issue in a core ticket. I've opened a new ticket, so I'll close this issue.

https://core.trac.wordpress.org/ticket/60535

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
@t-hamano t-hamano added the [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Development

No branches or pull requests

2 participants