Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert resized canvas and don't render resize handles when zoomed out #59389

Closed
t-hamano opened this issue Feb 27, 2024 · 1 comment · Fixed by #60104
Closed

Revert resized canvas and don't render resize handles when zoomed out #59389

t-hamano opened this issue Feb 27, 2024 · 1 comment · Fixed by #60104
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Experimental Experimental feature or API.

Comments

@t-hamano
Copy link
Contributor

Description

Enabling zoom-out view on resizable canvases such as template parts or patterns results in unnatural scroll bars. Also, when you move the resize handle, the canvas size seems to change unnaturally.

I think if zoomed-out view is enabled, we need to revert the resized canvas size and disable the resizing feature itself.

Step-by-step reproduction instructions

  • In advance, enable "Zoomed out view" on the "Experiments" page.
  • Open the site editor.
  • Open the pattern you created or one of the template parts.
  • Click the Zoom Out View button.
  • Play with the resizing handles and test how the canvas changes.

Screenshots, screen recording, code snippet

e00850dcf94e015228ada76f08358180.mp4

Environment info

Gutenberg 17.8.0-rc.2

Note: Zoom-out view is an experimental feature and is not available in WP6.5.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Type] Experimental Experimental feature or API. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 27, 2024
@richtabor
Copy link
Member

I think if zoomed-out view is enabled, we need to revert the resized canvas size and disable the resizing feature itself.

Agreed. I detailed the same in #60052. I'll close that in favor of this one.

@richtabor richtabor changed the title Zoom out view conflicts with resizable canvas Revert resized canvas and don't render resize handles when zoomed out Mar 21, 2024
@richtabor richtabor mentioned this issue Mar 21, 2024
39 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants