Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Save shortcut shouldn't open the save sidebar #59472

Closed
youknowriad opened this issue Feb 29, 2024 · 3 comments · Fixed by #59647
Closed

Site Editor: Save shortcut shouldn't open the save sidebar #59472

youknowriad opened this issue Feb 29, 2024 · 3 comments · Fixed by #59647
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Description

Using "cmd + s" (the save shortcut) in the site editor in edit mode is weird these days. You can see the save sidebar open for some milliseconds and then it closes itself.

We should avoid that middle step and just not open the sidebar at all.

Step-by-step reproduction instructions

1- Go to the site editor
2- Click a template/page or anything
3- Make some changes
4- Use the save shortcut ctrl+s or cmd+s

The sidebar should not "flash".

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 29, 2024
@annezazu
Copy link
Contributor

This would be a neat way to also solve this issue: #38714

@colorful-tones
Copy link
Member

This may help fix #59215 also.

@akasunil
Copy link
Contributor

akasunil commented Mar 2, 2024

I was able to reproduce this issue, and it only occurs on the initial load. If we make changes and save them again, the sidebar does not open.

CleanShot 2024-03-02 at 11 53 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants