Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancing site editor index views #59659

Open
20 of 31 tasks
SaxonF opened this issue Mar 7, 2024 · 20 comments
Open
20 of 31 tasks

Advancing site editor index views #59659

SaxonF opened this issue Mar 7, 2024 · 20 comments
Assignees
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@SaxonF
Copy link
Contributor

SaxonF commented Mar 7, 2024

Related #55083 #53322

What problem does this address?

As part of the admin track of work we want to start adopting some of the new UX paradigms within the site editor index views.

layout-motion.mp4

Pages and templates within the site editor currently drill-down the navigation sidebar showing a list of records, but what we want to work towards is always using the "content frame" for lists, including the "side by side" layout type which lets you quickly preview posts before editing. This also solves the weird "manage pages" and "manage templates" links that currently exist. The goal of this work is bring those "manage" pages forward so they are visible when visiting /pages or /templates, much like /patterns.

Tasks

Replace current pages with manage pages

Replace the existing pages view that shows pages in sidebar and update with the "manage pages" view. For this piece of work we can keep the "custom views" as experimental.

Old
image

New
image

Criteria:

Replace current templates with manage pages

Much like pages, we want to do the same for templates.

Old
image

New
image

Criteria:

  • Clicking "templates" in top level navigation opens templates data views with "grid" layout type enabled by default. Site Editor: update index page for templates #59792
  • Use grid layout by default with loading indicator. Index view for Templates & Parts: use grid layout as default #60069
  • Clicking template name in table view opens editor
  • Custom views for templates include default views [All, pages, posts, utility, custom]
  • When in side by side layout, clicking an item previews in the frame on right.
  • Clicking the frame expands into edit mode
  • Each item in side by side has an "edit" icon that expands frame into edit mode
  • Each item in side by side has an ellipsis icon that triggers templates actions

Updates patterns to remove template parts management

The current patterns page makes use of the new data views but we still have a "manage template parts" link. We should aim to remove that link and bring the missing functionality over to the patterns view.

Criteria:

@SaxonF SaxonF added the [Type] Enhancement A suggestion for improvement. label Mar 7, 2024
@youknowriad
Copy link
Contributor

Thanks for opening this issue, these are some nice flows.

Left sidebar remains at the top level with "templates" selected UNLESS "custom views" experiment is enabled

I think this one is going to be challenging to pull off, I'd navigate to "custom views" (or default views if the experiment is disabled) on the first iteration. We'd need stronger routing to be able to stay in the top view in the sidebar while navigating to templates.

"Manage template parts" link should go away

This item is also to be addressed with care, currently the patterns list view doesn't show "template parts", so it might mean "merging them", adding fields to filter one or the other... It might require its own issue for clarity.

@oandregal
Copy link
Member

oandregal commented Mar 12, 2024

Index for templates #59792

@SaxonF the screenshot for templates uses the table layout, though the texts mentions grid layout. Which one should be the default? The PR uses the existing (table).

@oandregal
Copy link
Member

#59858 makes the list layout stable, so it becomes available for Pages, Templates, and Parts without the experiment enabled.

@oandregal
Copy link
Member

Updates index for pages #59950

@oandregal
Copy link
Member

oandregal commented Mar 21, 2024

#60069 explores using grid layout for templates.

@annezazu annezazu added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Mar 22, 2024
@annezazu
Copy link
Contributor

Adding the tracking label to this as it tracks work across the experience and is part of the broader Overview issue of Data Views and Admin Redesign.

@oandregal
Copy link
Member

#60337 enables table layout for patterns.

@oandregal
Copy link
Member

#60345 removes "Manage all of my patterns" link.

@oandregal
Copy link
Member

oandregal commented Apr 2, 2024

#60359 looks at template parts in patterns (needs feedback on target design).

@oandregal
Copy link
Member

#60409 to display the content frame for Pages in mobile.

@oandregal
Copy link
Member

#60372 adds the author field & filter to the template parts in the Patterns page.

@getdave
Copy link
Contributor

getdave commented Apr 10, 2024

I'm wondering if any of this work should/could be extended to the Navigation (Menus) section?

In the past, we've received feedback that users would like to be able to edit (including ability to create) menus within the sidebar but I'm not sure that (especially editing) fits with the new UX paradigm outlined here.

Questions:

  1. Do we see Navigation making use of these new data views?
  2. Do we think Navigation Menus should be partially editable from these views, and if so how would that work?

Update: I noticed in #53322 there is a UI (see Example of the "drill down" below) which allows for drill down into individual entities from the "List" layout. This drill down could expose the UI for editing the Navigation Menu.

Example of the "drill down" Screen Shot 2024-04-10 at 10 56 43

Also I notice the term "Navigation" is being used a lot to described moving through "stacks" in the UI. That's fine, but just noting we may need to be careful to distinguish menus by referring to them as "Navigation Menus".

@SaxonF SaxonF changed the title WIP: Advancing site editor index views Advancing site editor index views Apr 11, 2024
@oandregal
Copy link
Member

#60659 adds edit and viewRevision actions to parts in Patterns page.

@oandregal
Copy link
Member

#60667 sets the backPath for Template Parts to the Patterns page.

@oandregal
Copy link
Member

#60689 removes the "Manage all parts" link, page, and code.

@oandregal
Copy link
Member

oandregal commented Apr 16, 2024

#60775 adds a "All template parts" section in the Patterns sidebar. It's a pre-requisite for #60689.

@oandregal
Copy link
Member

There's been a lot of activity in the Patterns screen and we're almost there: #60689 removes the "Manage template parts" link and old code. After this one lands, I'm focusing a bit on the DataViews component again – improving the list layout with actions, etc.

@oandregal
Copy link
Member

#60689 has landed and all listed tasks for Patterns are implemented. It's been a bit more involved than expected, and there's probably other things we need to polish now that this is ready.

Next, I'm planning to look at the task related to the DataViews component (list layout).

@SaxonF
Copy link
Contributor Author

SaxonF commented Apr 23, 2024

I wanted to highlight this issue because although it is not directly tied to data views it does become more important to solve after we've added the new 3 column layout. Once we close this work out, and the inspector, we should follow it up with responsive changes.

@oandregal
Copy link
Member

Based on @jameskoster comment, I've added some more tasks for consolidating Patterns/Parts:

Consolidate Patterns & Template Parts categories (#60689 (comment)):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
Status: No status
Development

No branches or pull requests

5 participants