Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link UI obscuring linked text in Site Editor #59840

Closed
getdave opened this issue Mar 13, 2024 · 6 comments
Closed

Link UI obscuring linked text in Site Editor #59840

getdave opened this issue Mar 13, 2024 · 6 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Regression Related to a regression in the latest release

Comments

@getdave
Copy link
Contributor

getdave commented Mar 13, 2024

In the Site Editor (only) when a new link has been created the resulting link preview is placed on top of the linked text. It should be offset as it is in the Post Editor.

Replication Steps

  • Open Site Editor
  • Navigate to Pages
  • Choose any page to edit
  • On that page add a paragraph block
  • Link some text and create the link
  • See the link preview obscures the linked text

Screencapture

Screen.Capture.on.2024-03-13.at.17-35-28.mp4
@getdave getdave added [Type] Regression Related to a regression in the latest release [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Mar 13, 2024
@getdave
Copy link
Contributor Author

getdave commented Mar 13, 2024

cc'ing contributors who I know have worked a lot on the Link UI in this cycle:

@jeryj @scruffian @draganescu (and me).

@jeryj
Copy link
Contributor

jeryj commented Mar 13, 2024

Is this only with Twenty Twenty Four?

@getdave
Copy link
Contributor Author

getdave commented Mar 13, 2024

Is this only with Twenty Twenty Four?

Oh wow. Yes it is! It seems it only happens in TT4. What's going on there I wonder and is this a bug with that Theme?

@jeryj
Copy link
Contributor

jeryj commented Mar 13, 2024

Maybe it's something with the default template files? If you save the template, the popover is positioned correctly. The bug seems isolated to unsaved (default) templates within TT4.

@getdave
Copy link
Contributor Author

getdave commented Mar 14, 2024

I verified this is not specific to the Link UI because the text highlight does the exact same thing:

Screen Shot 2024-03-14 at 09 48 37

I'm suspicious of useAnchor.

@getdave
Copy link
Contributor Author

getdave commented Mar 14, 2024

Ok I cannot replicate this any longer. I checked against RC2 and Gutenberg trunk. Possibly some kind of build error. It's very unusual.

Going to close.

@getdave getdave closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants