Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Loop Block doesn't accept 0 items per page anymore #59912

Closed
JulienGardair opened this issue Mar 15, 2024 · 2 comments
Closed

Query Loop Block doesn't accept 0 items per page anymore #59912

JulienGardair opened this issue Mar 15, 2024 · 2 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@JulienGardair
Copy link

Description

Query Loop Block doesn't accept 0 items per page anymore, when 0 is entered it is automatically reversed to 1.

Step-by-step reproduction instructions

Add QUERY LOOP BLOCK
choose Start Blank>Select a variation to start with>
any

Then BAR click on display settings
ITEMS PER PAGE [3 by default]
at the bottom is written
Limit the pages you want to show, even if the query has more results. To show all pages use 0 (zero).
But when trying to change to 0, it goes back to 1.

This appeared since the addition by default of the pagination and interactivity allowing to go to the next pages without refreshing the page which is great, but the possibility to display all the posts with appropriate filters seems to still be a necessary option.

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.4.3
Gutenberg 17.9.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@JulienGardair JulienGardair added the [Type] Bug An existing feature does not function as intended label Mar 15, 2024
@t-hamano t-hamano added the [Block] Query Loop Affects the Query Loop Block label Mar 17, 2024
@t-hamano
Copy link
Contributor

Thanks for the report.

Let me close this issue as the same issue has been reported in #51219.

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
@t-hamano t-hamano added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Mar 17, 2024
@JulienGardair
Copy link
Author

JulienGardair commented Mar 17, 2024

Sorry for the duplicate,
Also, I finally figured out what I was reading wrong:
"Limit the pages you want to show, even if the query has more results. To show all pages use 0 (zero)."
I assumed wrongly that this message was talking about the number of posts while it was talking about the number of pages that can be displayed in the pagination.
Sorry about this confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants