Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Hooks API: Creating a navigation post via POST request ignores hooked blocks meta. #60158

Open
tjcafferkey opened this issue Mar 25, 2024 · 0 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block hooks [Type] Bug An existing feature does not function as intended

Comments

@tjcafferkey
Copy link
Contributor

#59875 was introduced to fix a fatal error happening when the user creates a new Navigation by sending a POST request.

An potential bug (if we see it that way) we inherited as a result of this fix was that the next time the Navigation is loaded it will insert hooked blocks. This brings into question whether we should traverse the incoming post_content and generate ignoredHookedBlocks meta for it to prevent insertion of hooked blocks. The issue is that at the time of the request, we don't have a $post->ID to save this data against.

This was discussed in a little more detail here. #60071 (comment)

@tjcafferkey tjcafferkey added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Feature] Block hooks labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block hooks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant