Data Views: Pages: Improve clarity of the Trash and Permanently delete flows

[afercia]

Description

See previous similar issue #52639

From the Site editor > pages, a page can be 'moved to the trash'. Screenshot:

However, the confirm dialog that opens when trashing a page, asks users whether they want to delete the page. Screenshot:

That's less than ideal. It's confusing for users, as they will not trust the editor and potentially fear the page is going to be permantently deleted.

After confirming the action, a snackbar notice will confirm the page has been 'moved to the trash'. Screenshot:

Once the page is in the trash, useres can permanently delete it. One of the available actions is 'Permanently delete'. Screenshot:

After clicking Permanently delete' there is no confirmation step. The page is permanently deleted right away. A snackbar notice will confirm the permanent deletion:

Overall, I think this flow is unclear and confusing for users.

• I'm not sure whether the 'move to trash' action should go through a confirm dialog in the first place. That's not a destructive action. Anyways, the confirm dialog copy and the button text are wrong because they refer to 'delete'.
• The permanent deletion action doesn't go through a confirm step. This is a destructive action. I'd consider to add a confirm dialog to avoid data loss by accident.

Some history

Traditionally, the classic admin never implemented confirmation dialogs for the 'trash page' and 'delete permanently page' actions. The reasoning was that the first action isn't a destructive one. The second action is desctructive but users are in the context of hte 'trash' and it's clear enough that deelting from the trash deletes permanently.

Regardless od the historical approach illustrated above, it is worth considering whether it would be beneficial to think at a better flow. My 2 cents:

• The trash action shouldn't have a confirm dialog.
• The permantently delete action should have it.

Step-by-step reproduction instructions

• Go to the site editor > Pages > switch to the List view to make things more clear.
• Trash a page.
• Observe the confirmation dialog says 'delete'.
• Once the page is trashed, go to the Pages Trash section
• In the Actione menu for a page, click 'Delete permanently'.
• Observe there is no confirmation step.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[annezazu]

Just noting this as an overlapping issue with #46859 and #60072

cc @jameskoster as we seem to keep running into each other in issues around this general topic :D

[ammar-Mohamed-elz3eeem]

I would love to work on that as this was confusing for me to with all my 5 years developing WordPress sites
We need to give it a new feel like the mentioned one
So is this is a thing I can work on :)

[jameskoster]

Yes we went back and forth on page actions a bit, and it seems a regression snuck in somewhere.

I agree this seems backwards – moving to trash should not invoke a confirmation dialog, permanently deleting should.