Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ? indicator is missing from the url site params in site editor #60473

Closed
apeatling opened this issue Apr 4, 2024 · 2 comments
Closed

The ? indicator is missing from the url site params in site editor #60473

apeatling opened this issue Apr 4, 2024 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@apeatling
Copy link
Contributor

Description

When in the site editor, selecting the canvas to enter canvas editing mode the url looks like this: wp-admin/site-editor.phpcanvas=edit. The ? is missing.

Step-by-step reproduction instructions

  1. Open site editor
  2. Select a page to edit
  3. Click the canvas to enter editing mode
  4. Notice the URL and missing ?
  5. Refresh the page, the URL is busted.

Screenshots, screen recording, code snippet

No response

Environment info

Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@apeatling apeatling added the [Type] Bug An existing feature does not function as intended label Apr 4, 2024
@tyxla
Copy link
Member

tyxla commented Apr 4, 2024

Have you tried running npm install, optionally with npm run distclean beforehand?

This is likely because of #60271 which updated the package and the logic to add the ? or not in the same PR.

We did take a note that in the future we should keep those 2 separate (dependency update and logic update)

@apeatling
Copy link
Contributor Author

Yes this fixed it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants