Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus ring doesn't match button Site Hub Icon size #61339

Open
jeryj opened this issue May 2, 2024 · 1 comment · May be fixed by #61350
Open

Focus ring doesn't match button Site Hub Icon size #61339

jeryj opened this issue May 2, 2024 · 1 comment · May be fixed by #61350
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented May 2, 2024

Description

The site icon in the header of the site editor has a smaller focus ring.

Step-by-step reproduction instructions

  1. Use the keyboard to move focus to the site hub button
  2. The focus ring does not match the size of the site hub button

Screenshots, screen recording, code snippet

Open Navigation tooltip with focus ring about 8px inside of the edge of the site icon

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@jeryj jeryj added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time CSS Styling Related to editor and front end styles, CSS-specific issues. labels May 2, 2024
@vipul0425 vipul0425 linked a pull request May 3, 2024 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 3, 2024
@vipul0425
Copy link
Contributor

@jeryj I have raised the PR to fix this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Focus styles for site hub icon in site editor. vipul0425/gutenberg
2 participants
@jeryj @vipul0425