Refactor Featured Image Block to use aspectRatio block support

[fabiankaegy]

The featured image block currently has a manual control for handling the Aspect Ratio setting. This is redundant because we now have the aspectRatio block support which can handle this for us.

[hbhalodia]

Hi @fabiankaegy, I would like to take this up. I have scratch up my head a bit and found that we need to add the dimension support for the featured image and image core block. I have tried to implement the same, but seems to be a little tricky.

We need to remove the aspectRatio attribute from the attributes, but by removing this there are some functionality that is being used in the dimension control like, scale options

gutenberg/packages/block-library/src/post-featured-image/dimension-controls.js

Lines 99 to 100 in 613c05e

	const showScaleControl =
	height || ( aspectRatio && aspectRatio !== 'auto' );

which would be not being in use if we remove that. Once we remove that, since aspect ratio would be added to the main wrapper, that is figure here in case, for which we need to add the height and width 100% to make that work, which is also written based on the aspect ratio attribute

gutenberg/packages/block-library/src/post-featured-image/index.php

Lines 44 to 45 in 613c05e

	if ( ! empty( $attributes['aspectRatio'] ) ) {
	$extra_styles .= 'width:100%;height:100%;';

Now, if we need to remove the aspectRatio from attribute, we also need to make sure the backward compatibility for the same as well like deprecation something like that.

So can you please guide me on this, how can we approach this and what could be the starting point.

I tried to take some reference from the cover block, but it does not include the actual thing, it just has the aspectRatio dimension in the block support.

I see some reference 2e01f22#diff-7a048d7d7e1773a2805d9c622740508c9572015140912830a9ac81d5a0f9fe01 for the cover block. I hope this can be act as starting point for the same.

Thank You ✨.

[hbhalodia]

Hi @Mamaduka @fabiankaegy

I have raised the PR - #61485, to update the core/post-featured-image block to use the block Supports, dimensions aspectRatio instead of the aspectRatio attributes. Request you to review the PR and provide the suitable improvements.

Thank You 🙏.

[Mamaduka]

Thank you, @hbhalodia!

I'll try to have a look as soon as I've some free time.