-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataviews: Improve the 'No results' view #61442
Comments
In cases where no records exist, "No results found" reads a little strange, as does the accompanying text. In that scenario the messaging could be more focussed around adding the first |
The empty state is a slightly different use case (it appears without additional user input, like filtering), but I agree it'd use a similar treatment. Here's an attempt. The word It'd be nice to make the empty state extensible so third-party plugins could add extra elements, like buttons and buttons, without writing custom code. |
I wonder if it would make sense to implement this as a dedicated component, cc @WordPress/gutenberg-components. |
I think if we did that, it would make sense to be in dataviews package and just be a think wrapper with some base styles (border maybe, etc..). We have to think about what consumer would want there and if lots of flexibility is needed, they should be allowed to pass a component of their own. |
I agree that we could build a unified design pattern, even if it's being shared between two different components:
Explored both of these in the context of A4A and have a few suggestions:
|
Sounds like a very niche use case that I wouldn't recommend a generic component for. I don't see a good need for it because there's little to no interaction going on inside it. Also, there's a high chance that adding structure and providing a certain API won't cover certain use cases, making the component either useless or too limiting. |
Sounds good to me. The motivation is to be consistent in terms of design across data views, but still offer some flexibility. Features would likely include:
|
Sounds like we need some mockups then 😄 |
Yup we should make a detailed spec, the concepts shared already by Jarek and Filipe seem like good starting points. |
When users apply filters or search using terms that yield no results in the data views, the app currently says
No results
. I believe we can make it more helpful to users by tweaking the copy to focus on solutions and tailoring the message's appearance so it's easier to read and interact with.The button in the message would be contextual, meaning that it'd change depending on the context (
Add new page
,Add new post
,Add new pattern
, etc).The text was updated successfully, but these errors were encountered: