Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine how the 'Always open list view' preference should work #61498

Open
afercia opened this issue May 8, 2024 · 0 comments
Open

Refine how the 'Always open list view' preference should work #61498

afercia opened this issue May 8, 2024 · 0 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented May 8, 2024

Description

As a user, when I enable the 'Always open list view' preference, I would expect it to always stay open.

Instead, it closes when opening the main Block Inserter.

To me, this is unexpected. This unexoected closing already happens in WordPress 6.5 but it is now even more evident after #61004 which changes the Block Inserter beheavior to stay open when clicking outside of it.

Why the editor provides an 'Always open list view' preference when, instead, the List View actually closes automatically with no explicit user action to close it?

Also, I heard there are plans to reuse the same 'sidebar' panel for both the list view and the inserter. I do realize reusing code makes sense but how that is compatible with the 'Always open list view' preference?

Animated GIT to better illustrate:

stay open

Step-by-step reproduction instructions

  • Go to the post editor > Options > Preferences, and enable the 'Always open list view' preference.
  • Refresh the page.
  • Observe the List View panel is open and stays open when you use the editor.
  • Click 'Toggle block inserter' in the top bar, to open the main Inserter.
  • Observe the main inserter opens.
  • Observe the List View closes automatically. Observe it's not even rendered in the DOM.
  • Close the main inserger by either clicking the toggle button in the top bar or the Close button within the inserter.
  • Observe the List View panel does not re-opens. It stays closed.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant