Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering 'My patterns' category in the Inserter is a bit clunky #61826

Closed
jameskoster opened this issue May 21, 2024 · 3 comments
Closed

Filtering 'My patterns' category in the Inserter is a bit clunky #61826

jameskoster opened this issue May 21, 2024 · 3 comments
Assignees
@kevin940726
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Screenshot 2024-05-21 at 16 37 28
  1. My patterns will always be source=user(?); should that filter be hidden in this context?
  2. Why are synced/not synced options disabled?
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels May 21, 2024
@kevin940726
Copy link
Member

1. My patterns will always be source=user(?); should that filter be hidden in this context?

We can do that but I think we only kept them visible for consistency. Should we consider hiding it?

2. Why are synced/not synced options disabled?

I believe this is a bug accidentally introduced in #57570. I can file a PR fixing that.

@kevin940726 kevin940726 self-assigned this Jul 22, 2024
@jameskoster
Copy link
Contributor Author

We can do that but I think we only kept them visible for consistency. Should we consider hiding it?

Since the filter is presented local to the selected category, it seems superfluous to offer options can never be adjusted. Hiding is worth a try imo.

This was referenced Jul 23, 2024
Merged
Merged
@kevin940726
Copy link
Member

Closed by #63828 and #63831.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin940726 kevin940726

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameskoster @kevin940726