Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes Do Not Appear In Search Results #61938

Open
mrfoxtalbot opened this issue May 24, 2024 · 4 comments
Open

Footnotes Do Not Appear In Search Results #61938

mrfoxtalbot opened this issue May 24, 2024 · 4 comments
Labels
[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented May 24, 2024

Description

Text in the footnotes does not show in search results. This is because search only queries post_title, post_content and post_excerpt and has been a known issues for 7 years. https://core.trac.wordpress.org/ticket/40341

Step-by-step reproduction instructions

  1. Add a string of text to a footnote
  2. Look up that string of text in search
  3. No results are shown

Screenshots, screen recording, code snippet

String in a footnote:
Screenshot 2024-05-24 at 12 57 40

Search Results:
Screenshot 2024-05-24 at 12 42 12

Environment info

  • WordPress 6.5.3 + TT4
  • With and without the Gutenberg plugin.
  • No other plugins.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mrfoxtalbot mrfoxtalbot added [Type] Bug An existing feature does not function as intended [Block] Footnotes Affects the Footnotes Block labels May 24, 2024
@mrfoxtalbot mrfoxtalbot added the [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. label May 24, 2024
@Mamaduka
Copy link
Member

I think this is a core issue. Footnotes are stored in postmeta, which is rarely included in search queries due to performance.

In my opinion, any change we introduce here must be discussed in core tickets first.

@mrfoxtalbot
Copy link
Author

mrfoxtalbot commented May 24, 2024

Yup, I said so in the opening paragraph :)

This is because search only queries post_title, post_content and post_excerpt and has been a known issues for 7 years. https://core.trac.wordpress.org/ticket/40

I thought it made sense to open an issue for awareness as it has become more relevant with the introduction of foot notes.

I added a [Type} WP Core Ticket label.

@Mamaduka
Copy link
Member

@mrfoxtalbot, I get it. But this isn't actionable in the Gutenberg plugin, so I'm unsure what purpose the issue will serve.

@mrfoxtalbot
Copy link
Author

Sure, le me explain my logic: We have 20 issues labeled as [Type} WP Core Ticket: Requires an upstream change from WordPress. Core Trac ticket should be linked.

I thought this was a good example of such ticket: affects the block editor but is not directly fixable in the block editor's code and hence worth tracking but please let me know if I am misunderstanding something about this specific issue or about how this label should be used.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Development

No branches or pull requests

2 participants