Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI to Global styles to allow modification of font size presets #61987

Closed
matiasbenedetto opened this issue May 25, 2024 · 2 comments · Fixed by #63057
Closed

Add UI to Global styles to allow modification of font size presets #61987

matiasbenedetto opened this issue May 25, 2024 · 2 comments · Fixed by #63057
Assignees
@matiasbenedetto
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@matiasbenedetto
Copy link
Contributor

What?

Add UI to Global styles to allow modification of font size presets

Why?

This will allow users to edit the font size presets using the editor.
@matiasbenedetto matiasbenedetto added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels May 25, 2024
@matiasbenedetto matiasbenedetto self-assigned this May 25, 2024
@t-hamano t-hamano mentioned this issue May 27, 2024
Merged
@jasmussen jasmussen added the Needs Design Needs design efforts. label Jun 5, 2024
@matiasbenedetto matiasbenedetto mentioned this issue Jun 5, 2024
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 5, 2024
@matiasbenedetto
Copy link
Contributor Author

I started a potential implementation of this here: #62328

@matiasbenedetto matiasbenedetto mentioned this issue Jun 26, 2024
Draft
@annezazu
Copy link
Contributor

Just wanted to bring in feedback as the PR above gets underway that being able to control the font sizes on smaller devices is a major responsiveness related request I hear from folks. The latest look showing how you can toggle on an option to set custom fluid sizes will go a long way in addressing that! Excited to see this land and to get some testing done.

@matiasbenedetto matiasbenedetto mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasbenedetto matiasbenedetto

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Font size presets UI WordPress/gutenberg
Font size presets UI WordPress/gutenberg
3 participants
@jasmussen @matiasbenedetto @annezazu