Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/Redo and command+z #627

Closed
mtias opened this issue May 3, 2017 · 3 comments
Closed

Undo/Redo and command+z #627

mtias opened this issue May 3, 2017 · 3 comments
Assignees
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@mtias
Copy link
Member

mtias commented May 3, 2017

We should look at seeing how this could work together.

@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Enhancement A suggestion for improvement. labels May 3, 2017
@aduth aduth added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 26, 2017
@melchoyce
Copy link
Contributor

Just encountered this while trying to write a post — I tried undo via command+z, which instead of undoing my last action (unsuccessfully pasting a link on top of text), it deleted the entire text block content. I was then unable to redo to get my paragraph back.

@youknowriad
Copy link
Contributor

A compromise for this would be to make Ctrl+Z work like the current Ctrl+A. I mean:

  • When we're inside a text block (editable), it uses the regular TinyMCE history handler
  • When we're focusing something else, it triggers the global undo/redo actions

@jasmussen jasmussen added this to the Beta 0.8.0 milestone Jul 5, 2017
@mtias mtias modified the milestones: Beta 0.5.0, Beta 0.8.0, Beta 0.6.0 Jul 6, 2017
@abdul
Copy link

abdul commented Jul 16, 2017

I am sure this is known issue, however, let me state here:

Undo/Redo (via browser gui or shortcut keys) doesn't work when we change text style within Text block.

Steps:

  1. Add a Text Block
  2. Add some text
  3. Select Text
  4. Select "quote" or "list" or any other style
  5. Press CTRL+Z or CMD+Z or select Undo from browser GUI (Edit > Undo)

Actual Result: Text style doesn't revert to original style (normal)
Expected Result: Undo should work, in this case, text style should be reverted to original (normal text).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants