Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package @wordpress/i18n is missing dependency #7936

Closed
marcusig opened this issue Jul 12, 2018 · 4 comments · Fixed by #8062
Closed

package @wordpress/i18n is missing dependency #7936

marcusig opened this issue Jul 12, 2018 · 4 comments · Fixed by #8062
Labels
[Package] i18n /packages/i18n

Comments

@marcusig
Copy link

marcusig commented Jul 12, 2018 •
edited

Describe the bug
I'm using @wordpress/i18n on an other project than Gutenberg and since v1.2.0 I get the error Module not found: Error: Can't resolve '@babel/runtime/core-js/object/assign'

I can obviously add @babel/runtime to my project package.json, but if @wordpress/i18n is meant to be used in other projects, @babel/runtime should be part of the dependencies.

Unless I'm doing something wrong :)
@Soean Soean added the [Package] i18n /packages/i18n label Jul 12, 2018
@diegoreymendez
Copy link
Contributor

Another ocurrence of this being an issue: wordpress-mobile/gutenberg-mobile#71

@mmtr mmtr mentioned this issue Jul 19, 2018
Merged
@gziolo
Copy link
Member

gziolo commented Jul 19, 2018

I missed this one. Yes, it all makes sense. We need to update the list of dependencies for all packages that are transpiled with Babel. I should publish new version of such packages on Monday the latest 👍

@diegoreymendez diegoreymendez mentioned this issue Jul 19, 2018
Closed
@gwwar gwwar mentioned this issue Jul 19, 2018
Merged
@gziolo
Copy link
Member

gziolo commented Jul 20, 2018

Well, technically we need to publish those packages to npm. I hope to do it later today.

@gziolo
Copy link
Member

gziolo commented Jul 20, 2018 •
edited

@wordpress/i18n@1.2.1 is now available on npm with the fix:
https://unpkg.com/@wordpress/i18n@1.2.1/package.json

@diegoreymendez diegoreymendez mentioned this issue Jul 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] i18n /packages/i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add @babel/runtime as a dependency for packages WordPress/gutenberg
4 participants
@Soean @gziolo @diegoreymendez @marcusig