Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instagram embeds do not display properly while editing #8686

Closed
kriskarkoski opened this issue Aug 7, 2018 · 3 comments
Closed

Instagram embeds do not display properly while editing #8686

kriskarkoski opened this issue Aug 7, 2018 · 3 comments
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@kriskarkoski
Copy link

Describe the bug
Instagram embeds do not display in Gutenberg while editing. A placeholder for the image/video appears along with the correct caption, but never loads. The embed loads properly on the front-end

To Reproduce
Steps to reproduce the behavior:

  1. Add an Instagram embed
  2. Insert a valid URL (tested with https://www.instagram.com/p/BlbiuZ4g56e/)
  3. See the attempted embed with the caption, but no image/video displays, but does work on the front-end

Expected behavior
The image/video to be embeded as it appears on the front-end

Screenshots
screen shot 2018-08-07 at 3 31 38 pm

Desktop (please complete the following information):

OS: OS X 10
Browser: Chrome
Version 67.0.3396.99

Additional context
Gutenberg v3.4.0

@earnjam
Copy link
Contributor

earnjam commented Aug 7, 2018

@kriskarkoski This worked for me on my local test.
image

Do you get any errors in your browser javascript console when this happens?

@earnjam earnjam added the [Status] Needs More Info Follow-up required in order to be actionable. label Aug 7, 2018
@kriskarkoski
Copy link
Author

Thanks for testing so quickly. Looks like just a global one and nothing specific to this embed:

index.js?ver=1533063701:1 paragraphs block class set is-small-text, ..., is-large-text is deprecated and will be removed from Gutenberg in 3.6. Please use has-small-font-size, ..., has-large-font-size class set instead. Note: If paragraphs using this classes are opened in the editor new classes are automatically applied the post just needs to be saved. This is a global warning, shown regardless of whether the classes are used in the current post.

I see your site is http, where I was testing on https and thought that might be it but it doesn't work on an http site either. After some further testing it looks like this might be getting broken by Jetpack, which was on all the sites I tested before but disabling it allows the embed to show.

@earnjam
Copy link
Contributor

earnjam commented Aug 7, 2018

It looks like this has come up before in #3499 and there is an open ticket on the Jetpack repo too: Automattic/jetpack#9331

I'm going to close this as a duplicate. Thanks for reporting it!

@earnjam earnjam closed this as completed Aug 7, 2018
@earnjam earnjam added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants