Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview button will not open a new tab after user closes preview tab twice #8996

Closed
claudiobrandt opened this issue Aug 14, 2018 · 1 comment · Fixed by #8446
Closed

Preview button will not open a new tab after user closes preview tab twice #8996

claudiobrandt opened this issue Aug 14, 2018 · 1 comment · Fixed by #8446
Assignees
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended
Milestone

Comments

@claudiobrandt
Copy link

claudiobrandt commented Aug 14, 2018

Describe the bug
Using a standard 4.9.8 WP installation with Twenty Seventeen and the Gutenberg 3.5 plugin as the only activated plugin, when looking at or editing a post the Preview button works at first, and many times thereafter as long as the user does not close the preview tab. But it stops working properly after the second closing by the user of the tab where the preview was. (When the preview tab is not closed, the Preview button works as expected in refreshing the contents of the preview tab,) A link to a screencast is provided below.

Also, after content is changed the Preview will work as the "Save Draft" button next to it. Upon the first click on the Preview button, the message "Autosaving" will briefly appear, and the Save Draft" button is replaced with "Saved". Upon a second click, sometimes it does open a new tab with the preview content, sometimes it doesn't, depending on whether this is the second or third click after the review tab was closed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Dashboard > Posts > Post Title, open it to edit
  2. Click on Preview button. It should work normally at first.
  3. Click Preview many times, it will refresh each time, no problem
  4. Close the preview tab on the browser.
  5. Back to the editor, click again on Preview button, close the preview tab again.
  6. Do/undo little edits and click Preview button.

Expected behavior
A new tab should be opened, or the existing preview tab refreshed, displaying the contents of the page being edited no matter how many times the user has already closed the preview tab previously.

Screenshots
https://www.youtube.com/watch?v=mJchHQbOeCI

Desktop (please complete the following information):

  • OS: Windows 10 Pro 64 bits v. 1803
  • Browser: Chrome 64 bits
  • Browser: Firefox 61.0.2 (64-bit)
  • Version 68.0.3440.106
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Saving Related to saving functionality labels Aug 15, 2018
@designsimply
Copy link
Member

I tested and confirmed with WordPress 4.9.8 and Gutenberg 3.5.0 using Firefox 61.0.2 on macOS 10.13.6 that the Preview button becomes unresponsive after opening and closing preview tabs more than a couple times in a row. (1m9s)

Aside: the 400 response for the autosave API call shown in the video may be a separate bug and was noted at #7852 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants