Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Error' screen reader text to file integrity table #269

Conversation

audrasjb
Copy link

Short introduction

Description of what the PR accomplishes

Proposed HTML markup:

<tr>
   <td><span class="screen-reader-text">Error</span><span class="error"></span></td> 
   <td>/wp-admin/js/widgets.js</td><td>Content changed <a href="#health-check-diff" data-file="wp-admin/js/widgets.js">(View Diff)</a></td>
</tr>

PR Checklist

These are things to ensure are covered by your PR.

  • This PR is created against the develop branch
  • This PR is feature ready and can be reviewed in its entirety

@Clorith
Copy link
Member

Clorith commented Feb 27, 2019

I took your base here, and expanded on it in #278 as there were other locations also needing the same treatment 👍

@Clorith Clorith closed this Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants