Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-parameter expansion measures #151

Open
tomjn opened this issue Apr 19, 2021 · 0 comments · May be fixed by #159
Open

Anti-parameter expansion measures #151

tomjn opened this issue Apr 19, 2021 · 0 comments · May be fixed by #159

Comments

@tomjn
Copy link
Collaborator

tomjn commented Apr 19, 2021

A lot of the provisioners use statements such as this:

wme_clone_meta_repository $BASE_DIR

The problem here is that if $BASE_DIR contained a space, e.g. "test value" then it would expand to wme_clone_meta_repository test value not wme_clone_meta_repository "test value". This would allow additional parameters and commands to be included in unexpected places.

What Needs To Happen

Bare variables of the form $FOO need to be replaced with quoted versions e.g. "${BAR}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant