Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions in light of vvv-config.yml #82

Closed
iandunn opened this issue Nov 9, 2016 · 6 comments
Closed

Update installation instructions in light of vvv-config.yml #82

iandunn opened this issue Nov 9, 2016 · 6 comments

Comments

@iandunn
Copy link
Member

iandunn commented Nov 9, 2016

VVV now has a YAML config file to allow the user which default sites to provision, and it includes the Meta Environment as an option. See Varying-Vagrant-Vagrants/VVV#319 and
Varying-Vagrant-Vagrants/VVV#980.

It's off by default, but we can update our installation instructions to ask users to just uncomment that line and re-run the provisioner.

It looks like it'll install it to the wordpress-meta-environment directory (to avoid #9), but I haven't verified that. #9 should be fixable now though, also thanks to Varying-Vagrant-Vagrants/VVV#980.

@iandunn
Copy link
Member Author

iandunn commented Dec 14, 2016

@LoreleiAurora mentioned an issue in the install process that we should document.

When users install the Meta Environment via the new YAML file, the process runs after the hostsupdater plugin has ran, so they won't have the hosts defined during the first vagrant {up|provision}. We should have an installation step to run vagrant reload, so that the hostnames are added.

@jeremyfelt
Copy link
Member

@iandunn I think we'll have that fixed by the time 2.0.0 ships. The fewer steps the better. :)

@jeremyfelt
Copy link
Member

Ok, eating my words on this a bit. I'm still getting familiar myself. :)

If the domains are in the vvv-config.yml file, no reload would be necessary. But, in the case of the meta environment, we don't want to do that by default because there's quite a few. Those should be fed from the vvv-hosts in the project (which they are). In this case, a reload is needed to trigger hostsupdater.

I'm pretty sure that another vagrant up will trigger the same thing and not require the full reload process, but we'll need to test that.

@LoreleiAurora
Copy link

vagrant up will do that without going through a full reload.

@kevinwhoffman
Copy link

I wanted to share my experience trying to set up the Meta Environment for contributing to the Plugin Directory. It touches on some of the issues described above regarding hosts.

I ran my initial vagrant up with the Meta Environment lines uncommented in vvv-config.yml. While this provisioned the Meta sites, it did not update my hosts file and therefore I could not access wp-meta.dev or any of the Meta sites. This is confusing to first-timers trying to set up the Meta Environment. I fixed it by running vagrant provision again, but it would be good to automate that if possible, or at least communicate to the developer that an additional vagrant {up|provision} is required.

@ntwb
Copy link
Member

ntwb commented Apr 3, 2017

@kevinwhoffman Do have the Vagrant vagrant-hostsupdater plugin installed?

See https://github.com/WordPress/meta-environment/blob/master/docs/install.md#initial-setup

If you do, are you using Windows by any chance? I've a vague recollection that that can be troublesome on Windows

@iandunn iandunn closed this as completed in 9ce17a3 Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants