Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

/v1/thumbs should time out eventually (original #602) #17

Closed
obulat opened this issue Apr 21, 2021 · 2 comments
Closed

/v1/thumbs should time out eventually (original #602) #17

obulat opened this issue Apr 21, 2021 · 2 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🔧 tech: django Requires familiarity with Django 🐍 tech: python Requires familiarity with Python
Projects

Comments

@obulat
Copy link
Contributor

obulat commented Apr 21, 2021

This issue has been migrated from the CC Search Frontend repository

Author: aldenstpage
Date: Wed Aug 26 2020
Labels: 💻 aspect: code,🙅 status: discontinued,🛠 goal: fix,🟨 priority: medium

Description

If we are having a hard time loading a 3rd party image through our proxy, we should give up thumbnailing it. The frontend will fall back to the full sized image.

If we can't answer thumbnail requests quickly enough, our servers' workers become swamped with thumbnailing requests.


Original Comments:

Issue author tushar912 commented on Mon Sep 21 2020:

@aldenstpage I would like to work on this. Can u explain this issue a bit.
source

aldenstpage commented on Wed Sep 23 2020:

Hi @tushar912, I'd be happy to answer any specific questions you have about the ticket
source

manav1403 commented on Sun Oct 11 2020:

@aldenstpage Is it correct that for this issue we have to set a timeout on request when full size is false and if the request exceeds timeout then send the response of the full-sized image
and what should be the value of the timeout?
source

@dhruvkb dhruvkb added this to Backlog in Openverse Apr 29, 2021
@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community ✨ goal: improvement Improvement to an existing user-facing feature 🐍 tech: python Requires familiarity with Python 💻 aspect: code Concerns the software code in the repository 🔧 tech: django Requires familiarity with Django 🟩 priority: low Low priority and doesn't need to be rushed labels Feb 2, 2022
@zackkrida
Copy link
Member

@WordPress/openverse we have a timeout on this endpoint now, don't we?

@krysal
Copy link
Member

krysal commented Jul 6, 2022

Yes, we have it. Related to #630 and #756.

@krysal krysal closed this as completed Jul 6, 2022
Openverse automation moved this from Backlog to Done! Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🔧 tech: django Requires familiarity with Django 🐍 tech: python Requires familiarity with Python
Projects
No open projects
Openverse
  
Done!
Development

No branches or pull requests

4 participants