Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Prevent thumbnail timeout #756

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Prevent thumbnail timeout #756

merged 3 commits into from
Jun 18, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jun 15, 2022

Fixes

Fixes #695 by @AetherUnbound

Description

This PR prevents thumbnail errors from causing server crashes by

  • increasing timeout to 10s
  • catching more known exceptions
  • catching all unknown exceptions

Testing Instructions

  1. Check out the PR and run the dev server.
  2. Try generating thumbnails for many many images.
  3. You should not encounter any uncaught exceptions.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner June 15, 2022 06:43
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Jun 15, 2022
@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Jun 15, 2022
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/756

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

raise get_api_exception(f"Failed to render thumbnail: {exc}")
except Exception as exc:
raise get_api_exception(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice for debugging in the future :)

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried getting 10 thumbnails using a python script, and all returned 200 :)

Openverse PRs automation moved this from Needs review to Reviewer approved Jun 17, 2022
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@dhruvkb dhruvkb merged commit b114de9 into main Jun 18, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Jun 18, 2022
@dhruvkb dhruvkb deleted the thumb_timeout branch June 18, 2022 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

Thumbnail timeouts raise TimeoutError
4 participants