Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Delete resendoauthverification and resendoauthverification tests #1053

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Delete resendoauthverification and resendoauthverification tests #1053

merged 1 commit into from
Dec 19, 2022

Conversation

sahil-R
Copy link
Contributor

@sahil-R sahil-R commented Dec 19, 2022

Fixes

Fixes #1042 by @sarayourfriend

Description

The resendverificationemails command and test were taking too long to run,this pr will delete the command resendoauthverification and the tests related to it i.e resendoauthverification_test

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

delete the resendoauthverification and resendoauthverification_test to run api-test faster
@sahil-R sahil-R requested a review from a team as a code owner December 19, 2022 09:00
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Dec 19, 2022
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase labels Dec 19, 2022
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @sahil-R for your contribution 🙏

Openverse PRs automation moved this from Needs review to Reviewer approved Dec 19, 2022
@krysal krysal changed the title delete resendoauthverification and resendoauthverification_test Delete resendoauthverification and resendoauthverification tests Dec 19, 2022
@krysal krysal merged commit cd88d44 into WordPress:main Dec 19, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Dec 19, 2022
@sahil-R sahil-R deleted the Issue1042 branch December 20, 2022 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

Remove resendverificationemails command and tests
4 participants