Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add migration for removing ShortendLink #358

Merged
merged 1 commit into from Nov 17, 2021

Conversation

AetherUnbound
Copy link
Contributor

Description

This model was deprecated in #169 and removed in #295, but did not include a migration for removing it from the database. This PR adds that migration.

Testing Instructions

  1. just up
  2. docker-compose exec web python manage.py makemigrations should say No changes detected

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Nov 16, 2021
@AetherUnbound AetherUnbound requested review from dhruvkb, a team and obulat and removed request for a team November 16, 2021 16:21
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Nov 16, 2021
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool cool!

Openverse PRs automation moved this from Needs review to Reviewer approved Nov 16, 2021
Base automatically changed from fk_constraint to main November 17, 2021 09:57
@dhruvkb dhruvkb requested a review from a team as a code owner November 17, 2021 09:57
@AetherUnbound AetherUnbound merged commit b760ca1 into main Nov 17, 2021
Openverse PRs automation moved this from Reviewer approved to Merged! Nov 17, 2021
@AetherUnbound AetherUnbound deleted the bugfix/shortlink-migration branch November 17, 2021 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants