Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add a workflow to build our custom image for imaginary #641

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 11, 2022

Description

This PR tests the possibility of building a custom, up-to-date Docker image for h2non/imaginary.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added this to In progress in Openverse PRs Apr 11, 2022
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Apr 11, 2022
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Apr 11, 2022
@dhruvkb
Copy link
Member Author

dhruvkb commented Apr 12, 2022

The main issue with this approach is that the final container is not multi-architecture so it might not work well when running on a different architecture, like an M1 MacBook for example. In such a scenario, you would need to build the container locally rather than using it from GHCR directly. But a similar concern already exists for the h2non/imaginary image so 🤷.

Nonetheless, I'm working on building this in a cross-platform way, which is why this is a draft PR.

@dhruvkb dhruvkb marked this pull request as ready for review April 12, 2022 20:47
@dhruvkb dhruvkb requested a review from a team as a code owner April 12, 2022 20:47
@openverse-bot openverse-bot moved this from In progress to Needs review in Openverse PRs Apr 12, 2022
@dhruvkb dhruvkb merged commit a4d15c5 into compression Apr 12, 2022
Openverse PRs automation moved this from Needs review to Merged! Apr 12, 2022
@dhruvkb dhruvkb deleted the compression_img branch April 12, 2022 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

2 participants